Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Swift 5.8 #2924

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Drop support for Swift 5.8 #2924

merged 4 commits into from
Oct 17, 2024

Conversation

FranzBusch
Copy link
Member

Motivation

We only support the last three Swift released versions which are at this time 5.9, 5.10 and 6.

Modification

This PR drops anything related to Swift 5.8.

Result

Version support aligned.

README.md Outdated Show resolved Hide resolved
Sources/NIOCore/NIOScheduledCallback.swift Show resolved Hide resolved
@FranzBusch FranzBusch enabled auto-merge (squash) October 15, 2024 19:49
README.md Outdated Show resolved Hide resolved
# Motivation

We only support the last three Swift released versions which are at this time 5.9, 5.10 and 6.

# Modification

This PR drops anything related to Swift 5.8.

# Result

Version support aligned.
@FranzBusch
Copy link
Member Author

@glbrntt I kept the _scheduleCallback underscored since there is another scheduleCallback method on EL already that would conflict otherwise. That methods actually calls the underscored method.

@FranzBusch FranzBusch merged commit 2fe3d92 into main Oct 17, 2024
30 of 31 checks passed
@FranzBusch FranzBusch deleted the fb-drop-5.8 branch October 17, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/minor Adds new public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants